feat: allow attaching extra ping data on modern #1532
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TTtie
force-pushed
the
feat/modern-server-ping
branch
from
e325579 to
c5b82d2
Compare
This patch allows modern Minecraft servers to include additional match data in the ping response by splitting off extra ping data attachments into a ExtraPingDataRequestEvent that individual platforms can call with their own implementation that can be appropriately handled afterwards. On SP, this is handled as usual. On modern Minecraft, this is implemented using a ProtocolLib hook. Signed-off-by: TTtie <[email protected]>
TTtie
force-pushed
the
feat/modern-server-ping
branch
from
c5b82d2 to
ffed59b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows modern Minecraft servers to include additional match data in the ping response by splitting off extra ping data attachments into a ExtraPingDataRequestEvent that individual platforms can call with their own implementation that can be appropriately handled afterwards.
On SP, this is handled as usual. On modern Minecraft, this is implemented using a ProtocolLib hook (though I'm not sure if there's a better way to do this).
Also - is checking for "legacy SportPaper" still relevant?